Re: t7800 test failure

Matthieu Moy [off-list ref] writes:

Armin Kunaschik [off-list ref] writes:

quoted

t7800 fails on systems where readlink (GNUism?) is not available.

I don't think it's POSIX, but it is present on all POSIX-like systems I
know. On which system did you get the issue?

quoted

+readlink() { ls -ld "$1" | sed 's/.* -> //'; }

This is much less robust than the actual readlink. For example, if ->
appears in the link name, it breaks.

I wouldn't allow it in our scripted Porcelain, but the environment
of our test scripts are under our control, so I do not think it is a
problem ("ls piped to sed" has been an established idiom before
readlink(1) was widely accepted, by the way).

It would be acceptable as a fall-back if readlink is not present, but
shouldn't activate the "ls" hack by default.

Yup.