Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-16

Re: git log: invert --author and --committer

From: Per Cederqvist <hidden>
Date: 2016-06-16 02:19:34

Possibly related (same subject, not in this thread)

On Mon, May 23, 2016 at 9:26 PM, Junio C Hamano [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Junio C Hamano [off-list ref] writes:
quoted
Per Cederqvist [off-list ref] writes:
quoted
    git log --invert-grep --author cibot
...
Yeah, the author/committer search piggy-backs the more generic "grep
in the log" machinery, but it is quite hidden and the document
failed to tell the end users that is what is going on.  Mentioning
that invert (or any tweak that works on the grep machinery) affects
author/committer search is a good idea.

Does "-i/--regexp-ignore-case" also need the same treatment?
It seems it does.

How about making this clarification not about --invert-grep but
about --committer/--author option, perhaps like this?

 Documentation/rev-list-options.txt | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt
index 4f009d4..3fca366 100644
--- a/Documentation/rev-list-options.txt
+++ b/Documentation/rev-list-options.txt
@@ -44,6 +44,10 @@ endif::git-rev-list[]
        expression).  With more than one `--author=<pattern>`,
        commits whose author matches any of the given patterns are
        chosen (similarly for multiple `--committer=<pattern>`).
++
+Options that affect how a regular expression match is performed
+(such as `-i`, `-E`, `--invert-grep`) can also be used affect these
+options.

 --grep-reflog=<pattern>::
        Limit the commits output to ones with reflog entries that
"can also be used to affect", right? (I think the word "to" is missing.)

I think it does make sense to document this with the --author/--committer
options.

That wording would however make me assume that --all-match could also
be used, so that

    git log --all-match --author ceder --author cibot

would list nothing (since there are no authors that match both
"ceder" and "cibot" in this codebase).  That isn't the fact, though.
It seems to list all commits that have either ceder or cibot as author,
just as if I had not used --all-match.

As a reader of the man-page, I would prefer to have the exact list
of options in the documentation.  (I realize that it will make it harder
to maintain.)

    /ceder
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help