Thread (7 messages) flat view 7 messages, 1 author, 2016-06-16

Re: [PATCHv7 5/5] pathspec: allow querying for attributes

From: Stefan Beller <hidden>
Date: 2016-06-16 02:19:27

On Wed, May 18, 2016 at 12:02 PM, Stefan Beller [off-list ref] wrote:
 void free_pathspec(struct pathspec *pathspec)
 {
+       int i, j;
+       for (i = 0; i < pathspec->nr; i++) {
+               for (j = 0; j < pathspec->items[j].attr_match_nr; j++)
+                       free(pathspec->items[i].attr_match[j].value);
+               free(pathspec->items[i].attr_match);
+               git_attr_check_free(pathspec->items[i].attr_check);
This is faulty as may be NULL and git_attr_check_free assumes its
argument is not
NULL. So I'll add a guard here in a reoll.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help