Re: [PATCH v2 09/12] attr: (re)introduce git_check_attr() and struct git_attr_check

Eric Sunshine [off-list ref] writes:

This field is unused, and git_attr_check_initl() neglects to
initialize it (if it is intended to be used in the future).

There are two patterns to use the new API:

 - initl() variant is "initialize it once, never extend"; it is very
   much deliberate.  This is used by the majority of current
   callers, that know that they want a fixed set of attributes and
   can say what attributes they want upfront.

 - alloc then append variant will use the usual ALLOC_GROW() pattern
   with nr/alloc.