[PATCH v2 00/12] revamping git_check_attr() API · Junio C Hamano <hidden> · 2016-06-16
[PATCH v2 01/12] commit.c: use strchrnul() to scan for one line · Junio C Hamano <hidden> · 2016-06-16
Re: [PATCH v2 01/12] commit.c: use strchrnul() to scan for one line · Stefan Beller <hidden> · 2016-06-16
Re: [PATCH v2 01/12] commit.c: use strchrnul() to scan for one line · Junio C Hamano <hidden> · 2016-06-16
Re: [PATCH v2 01/12] commit.c: use strchrnul() to scan for one line · Stefan Beller <hidden> · 2016-06-16
[PATCH v2 04/12] attr.c: explain the lack of attr-name syntax check in parse_attr() · Junio C Hamano <hidden> · 2016-06-16
[PATCH v2 02/12] attr.c: use strchrnul() to scan for one line · Junio C Hamano <hidden> · 2016-06-16
Re: [PATCH v2 02/12] attr.c: use strchrnul() to scan for one line · Stefan Beller <hidden> · 2016-06-16
Re: [PATCH v2 02/12] attr.c: use strchrnul() to scan for one line · Junio C Hamano <hidden> · 2016-06-16
[PATCH v2 06/12] attr.c: mark where #if DEBUG ends more clearly · Junio C Hamano <hidden> · 2016-06-16
[PATCH v2 05/12] attr.c: complete a sentence in a comment · Junio C Hamano <hidden> · 2016-06-16
[PATCH v2 03/12] attr.c: update a stale comment on "struct match_attr" · Junio C Hamano <hidden> · 2016-06-16
Re: [PATCH v2 03/12] attr.c: update a stale comment on "struct match_attr" · Stefan Beller <hidden> · 2016-06-16
Re: [PATCH v2 03/12] attr.c: update a stale comment on "struct match_attr" · Junio C Hamano <hidden> · 2016-06-16
[PATCH v2 07/12] attr.c: simplify macroexpand_one() · Junio C Hamano <hidden> · 2016-06-16
[PATCH v2 08/12] attr: rename function and struct related to checking attributes · Junio C Hamano <hidden> · 2016-06-16
[PATCH v2 10/12] attr: convert git_all_attrs() to use "struct git_attr_check" · Junio C Hamano <hidden> · 2016-06-16
[PATCH v2 09/12] attr: (re)introduce git_check_attr() and struct git_attr_check · Junio C Hamano <hidden> · 2016-06-16
Re: [PATCH v2 09/12] attr: (re)introduce git_check_attr() and struct git_attr_check · Eric Sunshine <hidden> · 2016-06-16
[PATCH v2 12/12] attr: retire git_check_attrs() API · Junio C Hamano <hidden> · 2016-06-16
[PATCH v2 11/12] attr: convert git_check_attrs() callers to use the new API · Junio C Hamano <hidden> · 2016-06-16
Re: [PATCH v2 00/12] revamping git_check_attr() API · Stefan Beller <hidden> · 2016-06-16

STALE3731d

[PATCH v2 04/12] attr.c: explain the lack of attr-name syntax check in parse_attr()

From: Junio C Hamano <hidden>
Date: 2016-06-16 02:19:25
Subsystem: the rest · Maintainer: Linus Torvalds

Signed-off-by: Junio C Hamano <redacted>
---
 attr.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/attr.c b/attr.c
index 4ae7801..05db667 100644
--- a/attr.c
+++ b/attr.c

@@ -183,6 +183,12 @@ static const char *parse_attr(const char *src, int lineno, const char *cp,
 			return NULL;
 		}
 	} else {
+		/*
+		 * As this function is always called twice, once with
+		 * e == NULL in the first pass and then e != NULL in
+		 * the second pass, no need for invalid_attr_name()
+		 * check here.
+		 */
 		if (*cp == '-' || *cp == '!') {
 			e->setto = (*cp == '-') ? ATTR__FALSE : ATTR__UNSET;
 			cp++;

-- 
2.8.2-748-gfb85f76