Re: [PATCH 3/6] t9107: use "return 1" instead of "exit 1"
From: Junio C Hamano <hidden>
Date: 2016-06-16 02:19:23
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-16 · Re: [PATCH 3/6] t9107: use "return 1" instead of "exit 1" · Eric Wong <hidden>
- 2016-06-16 · Re: [PATCH 3/6] t9107: use "return 1" instead of "exit 1" · Eric Sunshine <hidden>
- 2016-06-16 · Re: [PATCH 3/6] t9107: use "return 1" instead of "exit 1" · Jeff King <hidden>
- 2016-06-16 · [PATCH 3/6] t9107: use "return 1" instead of "exit 1" · Jeff King <hidden>
Jeff King [off-list ref] writes:
On Fri, May 13, 2016 at 07:45:42PM -0400, Eric Sunshine wrote:quoted
quoted
+ >expect &&What's this 'expect' file for? Is it leftover gunk from before you settled on 'diff --exit-code'?Oops, yes, that's exactly it. -Peff
Thanks for sharp eyes. Let's squash this in, perhaps? t/t9107-git-svn-migrate.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t9107-git-svn-migrate.sh b/t/t9107-git-svn-migrate.sh
index 2908aef..b6a99b8 100755
--- a/t/t9107-git-svn-migrate.sh
+++ b/t/t9107-git-svn-migrate.sh@@ -80,12 +80,12 @@ test_expect_success 'multi-fetch works on partial urls + paths' ' git rev-parse --verify refs/remotes/origin/$i^0 || return 1; done >refs.out && test -z "$(sort <refs.out | uniq -d)" && - >expect && for i in $refs do for j in $refs do - git diff --exit-code refs/remotes/origin/$i refs/remotes/origin/$j || + git diff --exit-code refs/remotes/origin/$i \ + refs/remotes/origin/$j || return 1 done done