Thread (1 message) 1 message, 1 author, 2016-06-16

Re: [PATCH v2 16/94] builtin/apply: move 'update_index' global into 'struct apply_state'

From: Junio C Hamano <hidden>
Date: 2016-06-16 02:19:21

Christian Couder [off-list ref] writes:
quoted hunk
To libify the apply functionality the 'update_index' variable should
not be static and global to the file. Let's move it into
'struct apply_state'.

Reviewed-by: Stefan Beller <redacted>
Signed-off-by: Christian Couder <redacted>
---
 builtin/apply.c | 45 ++++++++++++++++++++++++++-------------------
 1 file changed, 26 insertions(+), 19 deletions(-)
diff --git a/builtin/apply.c b/builtin/apply.c
index 97af6ea..635a9ff 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -39,6 +39,7 @@ struct apply_state {
 	int check_index;
 
 	int unidiff_zero;
+	int update_index;
This should sit right next to check_index, I would think.

Otherwise looks correct.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help