Re: [PATCH v9 00/19] index-helper/watchman
flat view
From: Duy Nguyen <hidden>
Date: 2016-06-16 02:19:17
Possibly related (same subject, not in this thread)
- 2016-06-16 · Re: [PATCH v9 00/19] index-helper/watchman · Junio C Hamano <hidden>
- 2016-06-16 · Re: [PATCH v9 00/19] index-helper/watchman · Ramsay Jones <hidden>
- 2016-06-16 · Re: [PATCH v9 00/19] index-helper/watchman · Dennis Kaarsemaker <hidden>
- 2016-06-16 · Re: [PATCH v9 00/19] index-helper/watchman · Ramsay Jones <hidden>
- 2016-06-16 · [PATCH v9 00/19] index-helper/watchman · David Turner <hidden>
On Tue, May 10, 2016 at 7:45 PM, Duy Nguyen [off-list ref] wrote:
If --detach is used, log_warning() can't cover die(), warning() or error(), most importantly die() for example because of bugs.
A case for redirecting warning() is because watchman-support.c uses it. But because this file is only used by index-helper, you have another option, simply convert it to using log_warning(). -- Duy