Re: [PATCH v7 1/3] tests: Adjust the configuration for Apache 2.2

Hi Junio,

On Mon, 9 May 2016, Junio C Hamano wrote:

Johannes Schindelin [off-list ref] writes:

quoted

Okay, I already force-pushed my extra-http-header branch and the next
iteration will sport this paragraph.

The new explanation is well written and can and should also replace the
comment before the implementation in the configuration file to help
readers.

I picked your commit and force-pushed my branch; it will be part of the
next iteration.

To be honest, I do not quite understand why you call it "ugly hack"
at all.

Well, it is convoluted. I would have preferred to say "if this condition
is not met or that condition is not met, fail". Instead I had to say "If`
these two conditions are met, proceed as before. Otherwise, fail."

And of course its ugliness increased in my mind because I had to go
through so many iterations until it finally worked. Not really
straight-forward a solution.

quoted

Hopefully your patch to remove the -c ... sanitizing makes it to
`master` soon, then I can submit my next iteration.

Or we can just merge that "do not sanitize" branch in, and then queue
the "next iteration" which I'd assume would only be the test addition?

I'll prepare something.

Ciao,
Dscho