Thread (7 messages) flat view 7 messages, 3 authors, 2016-06-16

Re: [PATCH v2] t6302: simplify non-gpg cases

From: Eric Sunshine <hidden>
Date: 2016-06-16 02:19:16

On Mon, May 9, 2016 at 10:40 PM, Jeff King [off-list ref] wrote:
On Mon, May 09, 2016 at 01:47:35PM -0400, Eric Sunshine wrote:
quoted
quoted
-       test_prepare_expect <<-\EOF | sed -e "s/Z$//" >expect &&
+       cat <<-\EOF | sed -e "s/Z$//" >expect &&
To make this as close to a reversion as possible, this could be
restored to the original (sans 'cat'):

    sed -e "s/Z$//" >expect <<-\EOF &&
Thanks, I did the reversion with s/test_prepare_expect/cat/ rather than
reverting 618310a, but I agree dropping this useless-use-of-cat is worth
doing. Here's v2 with that change and your reviewed-by.
Looks good, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help