Re: [PATCH v3 1/2] rev-parse tests: add tests executed from a subdirectory
From: Junio C Hamano <hidden>
Date: 2016-06-16 02:19:14
Michael Rappazzo [off-list ref] writes:
t1500-rev-parse contains envrionment leaks (changing dir without changing back, setting config variables, etc). Add a test to clean this up up so that future tests can be added without worry of any setting from a previous test.
This is a wonderful thing to do, but...
quoted hunk
test_rev_parse toplevel false false true '' .git@@ -84,4 +85,41 @@ test_rev_parse 'GIT_DIR=../repo.git, core.bare = true' true false false '' git config --unset core.bare test_rev_parse 'GIT_DIR=../repo.git, core.bare undefined' false false true '' +test_expect_success 'cleanup from the previous tests' ' + cd .. && + rm -r work &&
Instead of cleaning things up like this, could you please please please fix these existing tests that chdir around without being in a subshell? If the "previous tests" failed before going down as this step expects, the "cd .. && rm -r" can make things worse.
+ mv repo.git .git && + unset GIT_DIR && + unset GIT_CONFIG &&
The spirit of this change is to make the test more independent from the effects of what happened previously. Use sane_unset so that we do not have to worry about previous step that may have failed before it has a chance to set GIT_DIR and GIT_CONFIG (which would cause these unset to fail).
+ git config core.bare $original_core_bare
Is this (rather, the capturing of $original_core_bare up above) necessary? We are in the default 'trash' repository when the capturing happens, and we know it is not a bare repository, right?