Re: [PATCH 80/83] run-command: make dup_devnull() non static

Hi Chris,

On Fri, 6 May 2016, Christian Couder wrote:

On Thu, May 5, 2016 at 10:07 PM, Johannes Sixt [off-list ref] wrote:

quoted

Am 05.05.2016 um 11:50 schrieb Christian Couder:

quoted

On Mon, Apr 25, 2016 at 5:05 PM, Johannes Schindelin
[off-list ref] wrote:

quoted

Hi Chris,

On Sun, 24 Apr 2016, Christian Couder wrote:

quoted

diff --git a/run-command.c b/run-command.c
index 8c7115a..29d2bda 100644
--- a/run-command.c
+++ b/run-command.c

@@ -85,7 +85,7 @@ static inline void close_pair(int fd[2])
  }

  #ifndef GIT_WINDOWS_NATIVE
-static inline void dup_devnull(int to)
+void dup_devnull(int to)
  {

The #ifndef GIT_WINDOWS_NATIVE rings very, very loud alarm bells.

Yeah, but I must say that I don't know what I should do about this.
Do you have a suggestion? Should I try to implement the same function
for Windows?

No, you should change the code that requires that ugly dup()ing so that it
can be configured to shut up.

quoted

No, just remove the #ifndef brackets. There is already code in
compat/mingw.c that treats the file name "/dev/null" specially.

Ok, I will do that in the same patch though the "#ifndef
GIT_WINDOWS_NATIVE" was already there before.

The idea was that compat/mingw.c is *really* only for the MINGW version,
not for the MSVC version.

Ciao,
Dscho