Thread (1 message) 1 message, 1 author, 2016-06-16

Re: [PATCH 1/2] bisect--helper: use OPT_CMDMODE instead of OPT_BOOL

From: Junio C Hamano <hidden>
Date: 2016-06-16 02:19:10

Eric Sunshine [off-list ref] writes:
quoted
+enum sub_commands {
How about calling this 'enum subcommand' (no underscore, non-plural)?
quoted
+       NEXT_ALL = 1
+};
+
 int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
 {
-       int next_all = 0;
+       int sub_command = 0;
s/sub_command/subcommand/
Non-plural is a good suggestion, but remember that you are using
OPT_CMDMODE to parse out that thing.  There is already a name for
that concept: "command name".  Why not name these after that phrase,
just like merge-base, replace, and tag already do?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help