Re: [WIP PATCH 00/14] Protocol v2 patches

On Mon, May 2, 2016 at 1:41 PM, David Turner [off-list ref] wrote:

On Fri, 2016-04-29 at 16:34 -0700, Stefan Beller wrote:

quoted

Hi David,

here are my patches for a protocol v2.

("Negotiate capabilities before doing anything else", or as code:

        static void upload_pack_version_2(void)
        {
                send_capabilities_version_2();
                receive_capabilities_version_2();

                /* The rest of the protocol stays the same,
capabilities advertising
                   is disabled though. */
                advertise_capabilities = 0;
                upload_pack();
        }
)

Overall, except for the comments I made, these patches seem sensible.

Would it be possible to add some docs on the new protocol when you re
-roll?  (I know these are just the initial patches, but it really helps
me to see an explanation along with the code).

Thanks for the review :) I'll fix the issues and add some docs, though
the reroll
may take some time. I really want to get the submodule groups stuff
done as well.