Re: [PATCH] t9824: fix wrong reference value

On 29 April 2016 at 21:29, Lars Schneider [off-list ref] wrote:

On 29 Apr 2016, at 19:34, Junio C Hamano [off-list ref] wrote:

quoted

Lars Schneider [off-list ref] writes:

quoted

0492eb4 fixed a broken &&-chain in this test which broke the test as it
checked for a wrong size. The expected size of the file under test is
39 bytes. The test checked that the size is 13 bytes. Fix the reference
value to make the test pass, again.

Signed-off-by: Lars Schneider <redacted>
---

That breaking "fix" seems to have been acked by you.

It was sort of clear that SZEDER didn't actually ran the test from
the patch, saying "As far as I can tell after eyeballing the test
script,", but you obviously didn't actually have a chance to test it
until now.

Thanks for fixing it before it hits 'master'; this time I think it
is safe to assume that this was actually tested ;-)

Yes! Lesson learned! Sorry Szeder!

How does the old saying go? If it hasn't been tested, it doesn't work!

Luke