Re: [PATCH 2/2] http: expand http.cookieFile as a path
From: Jeff King <hidden>
Date: 2016-06-16 02:19:04
On Fri, Apr 29, 2016 at 12:23:57AM -0600, Brian Norris wrote:
This should handle .gitconfig files that specify things like: [http] cookieFile = "~/.gitcookies"
Seems like a good idea, and the implementation looks obviously correct. For the documentation:
quoted hunk ↗ jump to hunk
diff --git a/Documentation/config.txt b/Documentation/config.txt index a775ad885a76..d3ef2d3b5d13 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt@@ -1660,6 +1660,9 @@ http.cookieFile:: in the Git http session, if they match the server. The file format of the file to read cookies from should be plain HTTP headers or the Netscape/Mozilla cookie file format (see linkgit:curl[1]). + The value of `http.cookieFile` is subject to tilde expansion: `~/` is + expanded to the value of `$HOME`, and `~user/` to the specified user's + home directory. NOTE that the file specified with http.cookieFile is used only as input unless http.saveCookies is set.
I'm not sure if it's a good idea to go into so much detail about expand_user_path() here. There are a lot of options that use the same rules, and we probably don't want to go into a complete explanation inside each option's description. Is there a canonical definition of how we do expansion in config.txt that we can just reference (and if not, can we add one)? -Peff