Thread (3 messages) flat view 3 messages, 3 authors, 2016-06-16

Re: [PATCH v2] trailer: load config to handle core.commentChar

From: Christian Couder <hidden>
Date: 2016-06-16 02:19:04

On Thu, Apr 28, 2016 at 10:00 PM, Rafal Klys [off-list ref] wrote:
Fall throught git_default_config when reading config to update the
comment_line_char from default '#' to possible different value set in
core.commentChar.

Signed-off-by: Rafal Klys <redacted>
---

Added fallthru instead of reading config third time.

Added test, updated commit message.

I even tried to change that to only one pass, but looks like it would require a
bit more coding, so maybe next time.

Thanks for feedback, I'm impressed that contributing to Git is so easy for
newbies (never sent a patch via email before!) and that the response is so
quick.
Thanks for contributing great patches and for the kind words!
I am also happy that you find it easy for newbies to contribute.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help