Re: [PATCH 19/29] refs: don't dereference on rename
From: Junio C Hamano <hidden>
Date: 2016-06-16 02:19:02
Michael Haggerty [off-list ref] writes:
quoted hunk
@@ -2380,8 +2381,8 @@ int rename_ref(const char *oldrefname, const char *newrefname, const char *logms goto rollback; } - if (!read_ref_full(newrefname, RESOLVE_REF_READING, sha1, NULL) && - delete_ref(newrefname, sha1, REF_NODEREF)) { + if (!read_ref_full(newrefname, resolve_flags, sha1, NULL) && + delete_ref(newrefname, NULL, REF_NODEREF)) {
Could you explain s/sha1/NULL/ here in the proposed log message?
if (errno==EISDIR) {
struct strbuf path = STRBUF_INIT;
int result;