Thread (1 message) 1 message, 1 author, 2016-06-16

Re: [PATCH v1] travis-ci: build documentation

From: Matthieu Moy <hidden>
Date: 2016-06-16 02:18:58

Junio C Hamano [off-list ref] writes:
Matthieu Moy [off-list ref] writes:
quoted
larsxschneider@gmail.com writes:
quoted
+      if [[ "$TRAVIS_OS_NAME" = linux ]] && [[ "$CC" = gcc ]];
[[ is a bashism, and doesn't bring anything here compared to the POSIX
[ ... ], or "test" which is prefered in Git's source code.

The ; or the newline is not needed either.
Honestly, I didn't know that we were even trying to be pure POSIX,
avoid bashism or GNUism, or in general to follow our shell scripting
style in the scriptlet in the .travis.yml file.
I'm not implying that we should absolutely avoid non-POSIX constructs,
just that the conjuction "non-POSIX + not useful" made me prefer to
remain POSIX.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help