Re: [PATCH 2/5] run-command: teach async threads to ignore SIGPIPE

On Thu, Apr 21, 2016 at 07:15:26AM +0200, Johannes Sixt wrote:

Am 20.04.2016 um 00:49 schrieb Jeff King:

quoted

This is our first use of pthread_sigmask, and I think Windows will have
to come up with something for this in compat/. I don't know how SIGPIPE
works there at all, so it's possible that we can just turn this into a
noop. Worst case it could probably block SIGPIPE for the whole process.

There is no SIGPIPE on Windows. write() always returns EPIPE as if SIGPIPE
was ignored.

We'll have to make pthread_sigmask() a no-op.

Great, thanks for clarifying. We can also #ifdef out the whole block
there if it's easier, but it looks like you already have noop
implementations for sigset, et al. So adding a noop pthread_sigmask()
should be enough.

-Peff