Re: [PATCH v4 15/16] index-helper: optionally automatically run

On Sun, 2016-04-17 at 12:19 +0700, Duy Nguyen wrote:

On Wed, Apr 13, 2016 at 7:33 AM, David Turner <
dturner@twopensource.com> wrote:

quoted

@@ -536,8 +567,10 @@ static void handle_builtin(int argc, const

char **argv)
        }

        builtin = get_builtin(cmd);
-       if (builtin)
+       if (builtin) {
+               maybe_run_index_helper(builtin);
                exit(run_builtin(builtin, argc, argv));
+       }
 }

Isn't it too early to start index-helper here? Unrelated commands
like
git-log are affected. And config handling this early could be tricky.
A better place may be in the socket connection code. When we fail to
connect, we can check config key and run index-helper then.

Will move.