Re: [PATCH v2 21/21] bisect: get back halfway shortcut
From: Junio C Hamano <hidden>
Date: 2016-06-16 02:18:49
Stephan Beyer [off-list ref] writes:
The documentation says that when the maximum possible distance
is found, the algorithm stops immediately. That feature is
reestablished by this commit.
Signed-off-by: Stephan Beyer <redacted>
---
Notes:
I plugged a memory leak here.... relative to patch series v1, I presume?
quoted hunk
@@ -391,7 +391,13 @@ static void traversal_up_to_merges(struct commit_list *queue, } update_best_bisection(top); + if (distance_direction(top) == 0) { // halfway
Say /* halfway */ without // double-slash comment. The remainder of the patch makes sense to me.