Re: [PATCH v2 13/21] bisect: use commit instead of commit list as arguments when appropriate
From: Junio C Hamano <hidden>
Date: 2016-06-16 02:18:49
Stephan Beyer [off-list ref] writes:
It makes no sense that the argument for count_distance() and halfway() is a commit list when only its first commit is relevant. Signed-off-by: Stephan Beyer <redacted> ---
Makes sense (modulo perhaps s/elem/commit/).
quoted hunk
bisect.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)diff --git a/bisect.c b/bisect.c index 4209c75..2c1102f 100644 --- a/bisect.c +++ b/bisect.c@@ -38,11 +38,11 @@ static inline struct node_data *node_data(struct commit *elem) return (struct node_data *)elem->util; } -static int count_distance(struct commit_list *entry) +static int count_distance(struct commit *elem) { int nr = 0; struct commit_list *todo = NULL; - commit_list_append(entry->item, &todo); + commit_list_append(elem, &todo);