Re: [PATCHv4 1/4] notes: don't leak memory in git_config_get_notes_strategy

Eric Sunshine [off-list ref] writes:

Meh. Rather than reverting the git_config_get_value(), it would have
been just as easy and safer (less chance of a future change
re-introducing a leak) if you had just inserted the necessary check
here:

    if (!value)
        return  config_error_nonbool(key);

Yup, sounds much more sensible fix that is useful in the longer term
(and avoids one unnecessary strdup()).

But, perhaps it's not worth the patch churn at this point...

quoted

        if (parse_notes_merge_strategy(value, strategy))
                git_die_config(key, "unknown notes merge strategy %s", value);

+       free(value);
        return 0;
 }

--
2.5.0.264.gc776916.dirty