Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 4/5] t/t5520: modify tests to reduce common code

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:09:06

Mehul Jain [off-list ref] writes:
There exist three groups of tests which have repetitive lines of code.

Introduce two functions test_rebase_autostash() and
test_rebase_no_autostash() to reduce the number of lines. Also introduce
loops to futher reduce the current implementation.
Sound like sensible idea.
+for i in true false
+	do
+		test_expect_success "pull --rebase --autostash & rebase.autostash=$i" '
+			test_config rebase.autostash $i &&
+			test_rebase_autostash
+		'
+	done
The lines between do..done is over-indented (will locally fix--no
need to resend).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help