Re: [PATCH 1/4] config --show-origin: report paths with forward slashes
From: Junio C Hamano <hidden>
Date: 2016-06-15 23:09:06
Possibly related (same subject, not in this thread)
- 2016-06-16 · Re: [PATCH 1/4] config --show-origin: report paths with forward slashes · Junio C Hamano <hidden>
- 2016-06-16 · Re: [PATCH 1/4] config --show-origin: report paths with forward slashes · Johannes Schindelin <hidden>
- 2016-06-16 · Re: [PATCH 1/4] config --show-origin: report paths with forward slashes · Johannes Sixt <hidden>
- 2016-06-15 · Re: [PATCH 1/4] config --show-origin: report paths with forward slashes · Johannes Sixt <hidden>
- 2016-06-15 · Re: [PATCH 1/4] config --show-origin: report paths with forward slashes · Johannes Sixt <hidden>
Johannes Sixt [off-list ref] writes:
quoted hunk
This part of your 45bf3297 (t1300: fix the new --show-origin tests on Windows)@@ -1205,6 +1205,9 @@ test_expect_success POSIXPERM,PERL 'preserves existing per "die q(badrename) if ((stat(q(.git/config)))[2] & 07777) != 0600" ' +! test_have_prereq MINGW || +HOME="$(pwd)" # convert to Windows path + test_expect_success 'set up --show-origin tests' ' INCLUDE_DIR="$HOME/include" && mkdir -p "$INCLUDE_DIR" &&is actually a much more concise version of my proposed patch, although the result still misuses $HOME where it does not have to. In fact, if I revert 5ca6b7bb (config --show-origin: report paths with forward slashes), the tests still pass. But since it does not make a difference save for a few microseconds more or less during startup, it is not worth the churn at this point.
Well, from the point of view of codebase cleanliness, if we can do without 5ca6b7bb4, we would be much better off in the longer term, so I would say it would be wonderful if we can safely revert it.