Thread (75 messages) flat view 75 messages, 4 authors, 2017-04-12

Re: [PATCH v1 1/7] Make it possible to get sha1 for a path from the index

From: Duy Nguyen <hidden>
Date: 2016-06-15 23:09:05

On Tue, Mar 29, 2016 at 8:28 PM, Duy Nguyen [off-list ref] wrote:
On Tue, Mar 29, 2016 at 8:25 PM,  [off-list ref] wrote:
quoted
From: Torsten Bögershausen <redacted>

Factor out the retrival of the sha1 for a given path in
read_blob_data_from_index() into the function get_sha1_from_index().
Getting _sha1_ from index is one function call and a memory
dereference or two. I think you mean get sha1 _file_ (or data) from
index. Maybe put either word in the function name.
Oops, shouldn't have trusted that function name in the @@ line. No
what you write in the commit message matches the patch. Sorry for the
noise.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help