Thread (23 messages) flat view 23 messages, 2 authors, 2016-06-15

Re: [PATCH v3/GSoC 2/5] path.c: implement xdg_runtime_dir()

From: Jeff King <hidden>
Date: 2016-06-15 23:08:58

On Fri, Mar 25, 2016 at 10:21:48PM +0800, 惠轶群 wrote:
quoted
There are some minor English problems here (and elsewhere). E.g., you
probably want "So we just issue a warning and leave it to the user to
solve.".
Sorry for my English.
Thanks. And sorry if that sounded too harsh. I know that working in a
non-native language is tough. Usually in a review I'll try to provide
specific English fixes, but in this case, I think a lot of these
messages are still in flux, so I I didn't want to waste either of our
time going over specifics if the content is just going to change later.
quoted
These ones leak, too.
I will deal with it.

I find there are some similar leakage in this file. I'll fix them in
another patch.
Great, thanks.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help