Re: [PATCH v2] worktree: add: introduce --checkout option

Thanks for the clarification.
By the way, Duy, another unrelated question: why worktree name under
.git/worktrees is being named
after the working tree path basename? I think branch name is more
reasonable since we don't allow checking out
the same branch twice.

2016-03-25 9:49 GMT+08:00 Duy Nguyen [off-list ref]:

On Fri, Mar 25, 2016 at 8:29 AM, Eric Sunshine [off-list ref] wrote:

quoted

On Thu, Mar 24, 2016 at 9:22 PM, Eric Sunshine [off-list ref] wrote:

quoted

On Thu, Mar 24, 2016 at 5:52 AM, Zhang Lei [off-list ref] wrote:

quoted

2016-03-24 17:16 GMT+08:00 Duy Nguyen [off-list ref]:

quoted

I think we can follow git-clone and use '-n' for this. [...]

My PATCH v1 did follow git-clone -n, however, Junio C Hamano and Eric Sunshine
suggested that we should avoid doing so , as --no-no-checkout could be
confusing.

My impression was that Duy was suggesting only that -n be recognized
as shorthand for --no-checkout, however, git-worktree already
recognizes -n as shorthand for --dry-run (as a consequence of using
OPT__DRY_RUN), so -n as shorthand for --no-checkout is a no-go.

Ignore this. It's only 'prune' which recognizes -n, so it's possible
that 'add' could recognize it for an alternate meaning (though the
documentation would want to make this very clear).

To make it clear, I don't feel strongly about '-n'. Yes muscle memory
may count. But if '-n' may become a new confusion source in
git-worktree then perhaps we should avoid it and go with
--[no-]checkout
--
Duy