[PATCH 10/21] resolve_ref_1(): reorder code
From: Michael Haggerty <hidden>
Date: 2016-06-15 23:08:54
Subsystem:
the rest · Maintainer:
Linus Torvalds
There is no need to adjust *flags if we're just about to fail. Signed-off-by: Michael Haggerty <redacted> --- refs/files-backend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/refs/files-backend.c b/refs/files-backend.c
index 69ec903..60f1493 100644
--- a/refs/files-backend.c
+++ b/refs/files-backend.c@@ -1542,13 +1542,13 @@ static const char *resolve_ref_1(const char *refname, return refname; } if (check_refname_format(refname, REFNAME_ALLOW_ONELEVEL)) { - *flags |= REF_ISBROKEN; - if (!(resolve_flags & RESOLVE_REF_ALLOW_BAD_NAME) || !refname_is_safe(refname)) { errno = EINVAL; return NULL; } + + *flags |= REF_ISBROKEN; bad_name = 1; } }
--
2.8.0.rc3