[PATCH v2 15/17] index-helper: autorun mode
From: David Turner <hidden>
Date: 2016-06-15 23:08:49
Subsystem:
the rest · Maintainer:
Linus Torvalds
Soon, we'll want to automatically start index-helper, so we need a mode that silently exists if it can't start up (either because it's not in a git dir, or because another one is already running). Signed-off-by: David Turner <redacted> --- index-helper.c | 29 +++++++++++++++++++++++------ t/t7900-index-helper.sh | 8 ++++++++ 2 files changed, 31 insertions(+), 6 deletions(-)
diff --git a/index-helper.c b/index-helper.c
index 7362abb..ab96ded 100644
--- a/index-helper.c
+++ b/index-helper.c@@ -368,8 +368,9 @@ done: int main(int argc, char **argv) { const char *prefix; - int idle_in_seconds = 600, detach = 0, kill = 0; + int idle_in_seconds = 600, detach = 0, kill = 0, autorun = 0; int fd; + int nongit; struct strbuf pipe_path = STRBUF_INIT; struct option options[] = { OPT_INTEGER(0, "exit-after", &idle_in_seconds,
@@ -378,6 +379,7 @@ int main(int argc, char **argv) "verify shared memory after creating"), OPT_BOOL(0, "detach", &detach, "detach the process"), OPT_BOOL(0, "kill", &kill, "request that existing index helper processes exit"), + OPT_BOOL(0, "autorun", &autorun, "this is an automatic run of git index-helper, so certain errors can be solved by silently exiting"), OPT_END() };
@@ -387,7 +389,14 @@ int main(int argc, char **argv) if (argc == 2 && !strcmp(argv[1], "-h")) usage_with_options(usage_text, options); - prefix = setup_git_directory(); + prefix = setup_git_directory_gently(&nongit); + if (nongit) { + if (autorun) + exit(0); + else + die("Not a git repository"); + } + if (parse_options(argc, (const char **)argv, prefix, options, usage_text, 0)) die(_("too many arguments"));
@@ -402,10 +411,18 @@ int main(int argc, char **argv) /* check that no other copy is running */ fd = open(pipe_path.buf, O_RDONLY | O_NONBLOCK); - if (fd > 0) - die(_("Already running")); - if (errno != ENXIO && errno != ENOENT) - die_errno(_("Unexpected error checking pipe")); + if (fd > 0) { + if (autorun) + return 0; + else + die(_("Already running")); + } + if (errno != ENXIO && errno != ENOENT) { + if (autorun) + return 0; + else + die_errno(_("Unexpected error checking pipe")); + } atexit(cleanup); sigchain_push_common(cleanup_on_signal);
diff --git a/t/t7900-index-helper.sh b/t/t7900-index-helper.sh
index ce0cc27..6020fe4 100755
--- a/t/t7900-index-helper.sh
+++ b/t/t7900-index-helper.sh@@ -33,4 +33,12 @@ test_expect_success 'index-helper will not start if already running' ' grep "Already running" err ' +test_expect_success 'index-helper is quiet with --autorun' ' + test_when_finished "git index-helper --kill" && + git index-helper --kill && + git index-helper --detach && + test -p .git/index-helper.pipe && + git index-helper --autorun +' + test_done
--
2.4.2.767.g62658d5-twtrsrc