Re: [PATCH v2/GSoC 4/4] t0301: test credential-cache support of XDG_RUNTIME_DIR

2016-03-18 13:01 GMT+08:00 Jeff King [off-list ref]:

On Fri, Mar 18, 2016 at 12:38:16PM +0800, 惠轶群 wrote:

quoted

quoted

quoted

+test_expect_success 'when $XDG_RUNTIME_DIR is set, `$XDG_RUNTIME_DIR/git` are used' '
+     test_path_is_missing "/tmp/git-$(id -u)/git/credential-cache.sock" &&
+     test -S "$HOME/xdg_runtime/git/credential-cache.sock"
+'

This test fails for me, probably because XDG_RUNTIME_DIR is not
exported.

-Peff

Could you please give a try to the patch set v2, test of which is
definitely passed on my computer.

Yes, that was what I tried earlier (and I just re-tested to make sure).
It still fails. I suspect it has to do with whether XDG_RUNTIME_DIR is
set in our environments (outside of the test suite). If I run:

  XDG_RUNTIME_DIR=/tmp/foo ./t0301-credential-cache.sh

it passes.

-Peff

Sorry, I wrongly considered your comment is for my last commit. That
was partly because my thread is
disturbed by my commits in my mailbox(gmail). I hope that did not also
disturb yours.

I sent my commits with `--thread` and `--no-chain-reply-to` in hope
that I would send an summary as
[PATCH 0/x] and all my commits would be sent in reply to it. But I failed.