Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [RFC/PATCH] Makefile: allow po generation through po target

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:08:47

Michael J Gruber [off-list ref] writes:
The main Makefile has a "pot" target that recreates the git.pot file of
strings which are marked for translation.

Add a "po" target that recreates the $(LANGUAGE).po files which contain
the translations (or stubs).

Signed-off-by: Michael J Gruber <redacted>
---

Notes:
    This makes it easier to recreate po (and mo) without reading po/README.
    Alternatively, one may think about a Makefile in po/ which does both pot
    and po updates, just like we have makefiles in t/ and Ducumentation/.
    
    This doesn't give you proper before-after diffs yet, but at least the after
    state.
More seriously, the "before state" does not exist anywhere, because
*.po and *.pot are expected not to be in sync with the source, and
after a code developer runs "make po", because she does not know all
the languages we have *.po for, she has to "git checkout" to erase
the changes made by "make po".

So while your starting discussion (i.e. RFC-ness of this patch) is
very much appreciated, I do not think this is a good change we would
want to base further work on top.  For "before-after-diff" purposes,
the targets for before and after should drop their output in an
untracked build artifact, instead of overwriting tracked files, I
would think.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help