Thread (18 messages) flat view 18 messages, 5 authors, 2016-06-15

Re: parse-options does not recognize "unspecified" behavior

From: Stefan Beller <hidden>
Date: 2016-06-15 23:08:46

On Wed, Mar 16, 2016 at 2:44 PM, Jeff King [off-list ref] wrote:
On Wed, Mar 16, 2016 at 05:37:03PM -0400, Eric Sunshine wrote:
quoted
A much easier solution would be to update OPT_VERBOSE() to understand
that negative values are "unspecified", and then --verbose would
(pseudocode):

    if (value < 0)
        value = 0
    value++;

and --no-verbose would:

    value = 0

That should be compatible with existing clients of OPT__VERBOSE()
which initialize the value to 0, and should satisfy Pranit's case; he
can initialize it to -1, and if it is still -1 when option parsing is
done, then he knows that neither --verbose nor --no-verbose was seen.
Yes, that makes much more sense to me. Thanks for the back-story.

-Peff
Is there any command which needs more than one --no-verbose?
(as an abuse to stacking --quiet multiple times)?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help