Re: [PATCH] help.c: strip suffix only if the STRIP_EXTENSION defined

On Wed, Mar 16, 2016 at 8:47 PM, Duy Nguyen [off-list ref] wrote:

On Wed, Mar 16, 2016 at 9:27 PM, Alexander Kuleshov
[off-list ref] wrote:

quoted

We stripping extension in the list_commands_in_dir() to get
commands without '.exe' suffix. Let's do it only if STRIP_EXTENSION
is defined to not spend time for unnecessary strip_suffix() call in
this case.

Unless the time saving is significant, I'm against this change. It
makes it harder to spot compile bugs in #ifdef'd code that's only
active on Windows (imagine somebody renames "ent" or change its type).
If you can do something like strip_extension() in git.c, it's better.
Or maybe just refactor that function a bit and share it with help.c

Yes, agree. Will think about this.