Thread (4 messages) flat view 4 messages, 4 authors, 2016-06-15

Re: [PATCH v2] submodule-config: use hashmap_iter_first()

From: Eric Sunshine <hidden>
Date: 2016-06-15 23:08:45

On Tue, Mar 15, 2016 at 3:21 PM, Stefan Beller [off-list ref] wrote:
On Tue, Mar 15, 2016 at 12:13 PM, Alexander Kuleshov
[off-list ref] wrote:
quoted
from the <hashmap.h> for simplification.
I think what Eric wanted to point out, was to not have a continuous sentence
from commit message header to body.
Yes, thanks for clarifying that.
Either leave the body blank (as it is obvious) or write a whole sentence there:

  [PATCH v2] submodule-config: use hashmap_iter_first()

  The hashmap API offers the `hashmap_iter_first` function as initializing and
  getting the first entry is a common pattern. Use that instead of
doing initialization
  by hand and then get the first entry.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help