Re: [PATCH v5] commit: add a commit.verbose config variable

On Mon, Mar 14, 2016 at 3:09 PM, Pranit Bauva [off-list ref] wrote:

On Mon, Mar 14, 2016 at 1:54 PM, Eric Sunshine [off-list ref] wrote:

quoted

Not at all mandatory, but it wouldn't hurt to add a couple additional tests:

* commit.verbose=true and --verbose
* commit.verbose=false and --no-verbose

I was thinking of putting these tests as when I was debugging (simply
by printing verbose variable), I found that when commit.verbose=true
and --verbose the value of the variable `verbose` is 2. But then I
thought it wouldn't be that useful. But since you have pointed it out
now, I will definitely include them.

The '2' is a result of OPT_VERBOSE() supporting multiple levels of
verbosity (that is, "--verbose --verbose" could give more noisy output
than "--verbose") for commands for which verbosity levels make sense.

In this case, I wasn't suggesting these news tests for that reason,
but merely to prove that the combinations behave in the expected way.
By the way, the just-submitted v6 seems to be lacking these new tests
(though, as I said, they are not by any means mandatory).