Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH/RFC v3] add a commit.verbose config variable

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:08:42

Pranit Bauva [off-list ref] writes:
On Fri, Mar 11, 2016 at 3:04 AM, Junio C Hamano [off-list ref]
wrote:
quoted
But doesn't this belong to git_commit_config(), not
git_STATUS_config()?  Should "commit.verbose" make output from "git
status" verbose?
True. It should belong to git_commit_config(). My bad. But
surprisingly this code works. I have no idea why. I will update the
Patch and I have also finished writing test so I will include that
also.
If that is surprising to you, that indicates that you only tested
"commit" and not "status", I think.  If you choose commit.verbose to
apply only to "commit", but not "status", then your test should
cover both commands, i.e. when the configuration is set to true, the
default verbosity level for "git commit" should be raised, and the
verbosity level for "git status" should not be--both must be
verified in your test script.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help