Re: [PATCH v4] fetch-pack: fix object_id of exact sha1

Jeff King [off-list ref] writes:

On Fri, Mar 04, 2016 at 10:11:38PM -0300, Gabriel Souza Franco wrote:

quoted

Commit 58f2ed0 (remote-curl: pass ref SHA-1 to fetch-pack as well,
2013-12-05) added support for specifying a SHA-1 as well as a ref name.
Add support for specifying just a SHA-1 and set the ref name to the same
value in this case.

Signed-off-by: Gabriel Souza Franco <redacted>
---
 Documentation/git-fetch-pack.txt |  4 ++++
 builtin/fetch-pack.c             | 16 +++++++++++++---
 t/t5500-fetch-pack.sh            | 14 ++++++++++++++
 3 files changed, 31 insertions(+), 3 deletions(-)

Thanks, this version looks good to me.

It does to me too, but unfortunately the previous one is already in
'next'.  Something like this as an incremental update would suffice.

-- >8 --
From: Gabriel Souza Franco <redacted>
Date: Fri,  4 Mar 2016 22:11:38 -0300
Subject: fetch-pack: update the documentation for "<refs>..." arguments

When we started allowing an exact object name to be fetched from the
command line, we forgot to update the documentation. 

Signed-off-by: Gabriel Souza Franco <redacted>
--
 Documentation/git-fetch-pack.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/git-fetch-pack.txt b/Documentation/git-fetch-pack.txt
index 8680f45..239623c 100644
--- a/Documentation/git-fetch-pack.txt
+++ b/Documentation/git-fetch-pack.txt

@@ -104,6 +104,10 @@ be in a separate packet, and the list must end with a flush packet.
 	The remote heads to update from. This is relative to
 	$GIT_DIR (e.g. "HEAD", "refs/heads/master").  When
 	unspecified, update from all heads the remote side has.
++
+If the remote has enabled the options `uploadpack.allowTipSHA1InWant` or
+`uploadpack.allowReachableSHA1InWant`, they may alternatively be 40-hex
+sha1s present on the remote.
 
 SEE ALSO
 --------