Thread (1 message) 1 message, 1 author, 2016-06-15

Re: git diff does not precompose unicode file paths (OS X)

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:08:37

Alexander Rinass [off-list ref] writes:
Sticking a precompose_argv(argc, argv) into diff.c’s cmd_diff
function fixes the issue.

But I had to disable the check (precomposed_unicode != 1) in
precompose_argv to make it work. That’s probably because
precompose_argv is usually called from parse_options and is
missing some other call before it?
The "precomposed_unicode" bit comes from your configuration file,
so it won't be usable before you call into git_default_core_config
and that happens via a call to "git_config(git_diff_ui_config, NULL)".

So perhaps you'd want to add the argv munging immediately before
init_revisions() call there?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help