Re: [PATCH v2] Mark win32's pthread_exit() as NORETURN
From: <hidden>
Date: 2016-06-15 23:08:34
Am 01.03.2016 um 15:13 schrieb Johannes Schindelin:
The pthread_exit() function is not expected to return. Ever. On Windows, we call ExitThread() whose documentation claims: "This function does not return a value.":
Does this really mean that ExitThread() does not return ? Just wondering...
quoted hunk ↗ jump to hunk
https://msdn.microsoft.com/en-us/library/windows/desktop/ms682659 Pointed out by Jeff King. Signed-off-by: Johannes Schindelin <redacted> --- Relative to v1, only the commit message changed (to clarify that ExitThread() indeed never returns). compat/win32/pthread.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h index 20b35a2..148db60 100644 --- a/compat/win32/pthread.h +++ b/compat/win32/pthread.h@@ -78,7 +78,7 @@ extern int win32_pthread_join(pthread_t *thread, void **value_ptr); #define pthread_equal(t1, t2) ((t1).tid == (t2).tid) extern pthread_t pthread_self(void); -static inline int pthread_exit(void *ret) +static inline int NORETURN pthread_exit(void *ret) { ExitThread((DWORD)(intptr_t)ret); } --
Stefan
--
----------------------------------------------------------------
/dev/random says: We're lost, but we're making good time.
python -c "print '73746566616e2e6e616577654061746c61732d656c656b74726f6e696b2e636f6d'.decode('hex')"
GPG Key fingerprint = 2DF5 E01B 09C3 7501 BCA9 9666 829B 49C5 9221 27AF