Re: [PATCH v1] git-p4: map a P4 user to Git author name and email address
flat view
From: Luke Diamand <hidden>
Date: 2016-06-15 23:08:32
On 28 February 2016 at 10:25, [off-list ref] wrote:
From: Lars Schneider <redacted> Map a P4 user to a specific name and email address in Git with the "git-p4.mapUser" config. The config value must be a string adhering to the format "p4user -> First Lastname [off-list ref]".
Seems generally fine. I agree with Eric's comments about the "->" format. One comment below:
quoted hunk ↗ jump to hunk
+test_expect_success 'Clone repo root path with all history' ' + client_view "//depot/... //client/..." && + test_when_finished cleanup_git && + ( + cd "$git" && + git init . && + git config --add git-p4.mapUser "mmax -> Max Mustermann <max@muster.com>" && + git config --add git-p4.mapUser "mo -> Moritz Untreu <moritz@untreu.com>" &&
Probably better to use more innocuous names. I'm not sure who these people are, but they might not appreciate being recorded forver in a git-p4 test script. Luke