Thread (9 messages) flat view 9 messages, 5 authors, 2017-05-10

Re: [PATCH v2] add DEVELOPER makefile knob to check for acknowledged warnings

From: Lars Schneider <hidden>
Date: 2016-06-15 23:08:29

On 26 Feb 2016, at 10:26, Duy Nguyen [off-list ref] wrote:

On Thu, Feb 25, 2016 at 3:42 PM,  [off-list ref] wrote:
quoted
+ifdef DEVELOPER
+       CFLAGS +=       -Werror \
+                               -Wdeclaration-after-statement \
+                               -Wno-format-zero-length \
+                               -Wold-style-definition \
+                               -Woverflow \
+                               -Wpointer-arith \
+                               -Wstrict-prototypes \
+                               -Wunused \
+                               -Wvla
With the exception of $(SCRIPTS) in Makefile, I think we prefer to
avoid \ and have one addition per statement
I guessed that because I actually looked through the makefile to find how you deal with line 
brakes. The problem here was that this line gets really long and then it is hard to see what 
warnings are enabled.
Would you be OK with using \ for readability here?

Thanks,
Lars
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help