[PATCH v2 00/20] Delete directories left empty after ref deletion · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 04/20] lock_ref_sha1_basic(): use raceproof_create_file() · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 06/20] rename_tmp_log(): improve error reporting · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 05/20] rename_tmp_log(): use raceproof_create_file() · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 11/20] log_ref_setup(): manage the name of the reflog file internally · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 12/20] log_ref_write_1(): inline function · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 13/20] try_remove_empty_parents(): rename parameter "name" -> "refname" · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 14/20] try_remove_empty_parents(): don't trash argument contents · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 16/20] t5505: use "for-each-ref" to test for the non-existence of references · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 17/20] delete_ref_loose(): derive loose reference path from lock · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 20/20] ref_transaction_commit(): clean up empty directories · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 18/20] delete_ref_loose(): inline function · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 19/20] try_remove_empty_parents(): teach to remove parents of reflogs, too · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 15/20] try_remove_empty_parents(): don't accommodate consecutive slashes · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 02/20] safe_create_leading_directories(): set errno on SCLD_EXISTS · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 03/20] raceproof_create_file(): new function · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 07/20] log_ref_setup(): separate code for create vs non-create · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 10/20] log_ref_write_1(): don't depend on logfile · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 08/20] log_ref_setup(): improve robustness against races · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 01/20] safe_create_leading_directories_const(): preserve errno · Michael Haggerty <hidden> · 2016-06-15
[PATCH v2 09/20] log_ref_setup(): pass the open file descriptor back to the caller · Michael Haggerty <hidden> · 2016-06-15

DORMANTno replies

Revision v2 of 4 in this series.

Revisions (4)

2016-06-15 v1 [diff vs current]
2016-06-15 v2 current
2016-12-31 v3 [diff vs current]
2017-01-06 v4 [diff vs current]

[PATCH v2 06/20] rename_tmp_log(): improve error reporting

From: Michael Haggerty <hidden>
Date: 2016-06-15 23:08:27
Subsystem: the rest · Maintainer: Linus Torvalds

* Don't capitalize error strings
* Report true paths of affected files

Signed-off-by: Michael Haggerty <redacted>
---
 refs/files-backend.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/refs/files-backend.c b/refs/files-backend.c
index 2cb402d..ed29b3b 100644
--- a/refs/files-backend.c
+++ b/refs/files-backend.c

@@ -2430,10 +2430,11 @@ static int rename_tmp_log(const char *newrefname)
 	ret = raceproof_create_file(path, rename_tmp_log_callback, &true_errno);
 	if (ret) {
 		if (true_errno == EISDIR)
-			error("Directory not empty: %s", path);
+			error("directory not empty: %s", path);
 		else
-			error("unable to move logfile "TMP_RENAMED_LOG" to logs/%s: %s",
-				newrefname, strerror(true_errno));
+			error("unable to move logfile %s to %s: %s",
+			      git_path(TMP_RENAMED_LOG), path,
+			      strerror(true_errno));
 	}
 
 	free(path);

-- 
2.7.0