Re: [PATCH v2] git: submodule honor -c credential.* from command line

On Wed, Feb 24, 2016 at 10:23 PM, Jeff King [off-list ref] wrote:

On Wed, Feb 24, 2016 at 10:19:05PM -0800, Jacob Keller wrote:

quoted

quoted

quoted

+               /* combined all the values before we quote them */

Comment repeats what the code already says, thus not terribly useful.

Also: s/combined/combine/

I tend to make comments like this when I change the obvious way it was
done, I commented this because I based it on a scratch patch from Jeff
that didn't have them put together before quoting.

That's a good point. The _what_ is not interesting here, but the _why_
might be. Namely that we must quote the whole thing as a unit, or the
parser on the receiving end will not be able to read it.

I can reword the comment to explain the _why_

I'd also be amenable to relaxing the parser (which is as strict as it is
only out of laziness, and the fact that it was reading the output only
of its nearby generator function). But I can understand if you don't
feel like digging into that.

-Peff

I really don't want to dig that far into it. I think that working
within the current parser is just fine.

Regards,
Jake