Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] git: submodule honor -c credential.* from command line

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:08:26

Jacob Keller [off-list ref] writes:
quoted
quoted
quoted
Add a git submodule--helper function which can be used to sanitize the
GIT_CONFIG_PARAMETERS value to only allow certain settings. For now,
restrict this to only credential.* settings.
I guess for now that subset is fine and will be expanded over time?
I think it is more like "we pass only what is known to be necessary
and safe, and right now, credential.* are the only such variables."

As the system evolves more, theoretically we might find more, but
let's not phrase it as if expanding is a good thing and a longer
term goal.
I can reword the commit message to that effect.
I think what you wrote was perfectly fine.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help