Re: [PATCH 1/3] t3034: add rename threshold tests
flat view
From: Eric Sunshine <hidden>
Date: 2016-06-15 23:08:24
On Tue, Feb 23, 2016 at 7:50 PM, Eric Sunshine [off-list ref] wrote:
On Tue, Feb 23, 2016 at 6:48 PM, Felipe Gonçalves Assis [off-list ref] wrote:quoted
+ if [ 50 -le "$th0" ]; then + check_50=check_threshold_0 + elif [ 50 -le "$th1" ]; then + check_50=check_threshold_1 + elif [ 50 -le "$th2" ]; then + check_50=check_threshold_2 + fi &&
Oh, I totally forgot to mention a few style issues:
1. use 'test' rather than '['
2. place 'then' on its own line
3. drop semicolon
if test 50 -le "$th0"
then
...
elif test ...
then
...