Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v2 6/6] wt-status: read rebase todolist with strbuf_getline()

From: Junio C Hamano <hidden>
Date: 2016-06-15 23:08:21

Moritz Neeb [off-list ref] writes:
quoted hunk
diff --git a/wt-status.c b/wt-status.c
index ab4f80d..8047cf2 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -1076,10 +1076,9 @@ static void read_rebase_todolist(const char *fname, struct string_list *lines)
 	if (!f)
 		die_errno("Could not open file %s for reading",
 			  git_path("%s", fname));
-	while (!strbuf_getline_lf(&line, f)) {
+	while (!strbuf_getline(&line, f)) {
Not related to the substance of the patch series at all, but all
except for this patch in the series seem to be corrupt in that the
very first line that is removed in each patch has an extra space
before the '-' deletion sign.  It is a very curious symptom.  Please
double check the way you send out patch e-mails (e.g. send them
first only to yourself and then try to apply them with "git am").

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help