Thread (4 messages) flat view 4 messages, 1 author, 2016-06-15
DORMANTno replies

Revision v5 of 5 in this series.

Revisions (5)
  1. v3 [diff vs current]
  2. v4 [diff vs current]
  3. v5 current
  4. v6 [diff vs current]
  5. v6 [diff vs current]

[PATCH v5 0/3] config: add '--sources' option to print the source of a config value

From: <hidden>
Date: 2016-06-15 23:08:17

From: Lars Schneider <redacted>

diff to v4:
* improve wording of "exit code" cleanup commit message (Thanks Peff)
* remove t1300 "--show-origin" test teardown (Thanks Peff)
* fix no parameter function prototype (Thanks Ramsay)
* use doublequotes instead of tabs to test quoted paths (Thanks Junio)

I though a while about Ramsay's suggestion to restore the old error messages
for config reads via stdin. Since reading the config via stdin is not that
common I don't think the increased complexity is worth the effort. Unless
Ramsay or someone else feels strongly about it, I would like to proceed and
keep the new error messages

Thanks for the review,
Lars


Lars Schneider (3):
  t: do not hide Git's exit code in tests using 'nul_to_q'
  config: add 'type' to config_source struct that identifies config type
  config: add '--show-origin' option to print the origin of a config
    value

 Documentation/git-config.txt |  15 ++--
 builtin/config.c             |  33 +++++++++
 cache.h                      |   6 +-
 config.c                     |  36 +++++++---
 submodule-config.c           |   4 +-
 t/t1300-repo-config.sh       | 161 ++++++++++++++++++++++++++++++++++++++++++-
 t/t1308-config-set.sh        |   4 +-
 t/t7008-grep-binary.sh       |   3 +-
 8 files changed, 236 insertions(+), 26 deletions(-)

--
2.5.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help