Thread (9 messages) 9 messages, 1 author, 2016-06-15

Re: [PATCHv10 5/7] git submodule update: have a dedicated helper for cloning

From: Stefan Beller <hidden>
Date: 2016-06-15 23:08:12

On Thu, Feb 11, 2016 at 6:03 PM, Stefan Beller [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This introduces a new helper function in git submodule--helper
which takes care of cloning all submodules, which we want to
parallelize eventually.

Some tests (such as empty URL, update_mode=none) are required in the
helper to make the decision for cloning. These checks have been
moved into the C function as well (no need to repeat them in the
shell script).

Signed-off-by: Stefan Beller <redacted>
---
 builtin/submodule--helper.c | 236 ++++++++++++++++++++++++++++++++++++++++++++
 git-submodule.sh            |  45 +++------
 2 files changed, 247 insertions(+), 34 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index f4c3eff..e865fca 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -255,6 +255,241 @@ static int module_clone(int argc, const char **argv, const char *prefix)
        return 0;
 }

+static int git_submodule_config(const char *var, const char *value, void *cb)
+{
+       return submodule_config(var, value, cb);
+}
This is the thing I forgot to address.
Next reroll will inline submodule_config directly.

Stefan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help